BED-4868 Wrong Reader Count for AZKeyVaults #1017
Open
+132
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the endpoint, which EntityInfoDataTable can look at for help getting the correct count for top level Vault Readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a field
countLabelto the data returned by the endpoint in content.ts This can then be picked up by the EntityInfoDataTable so it can use the correct count for parent objects where needed.Motivation and Context
This PR addresses: https://specterops.atlassian.net/browse/BED-4868
How Has This Been Tested?
Import the azure example data. Search for 'keyvault' in the explorer and select PHANTOMKEYVAULT-01. The key readers dialog should show 2, not 8.
I have also added a test to EntityInfoDataTable.test.tsx
Types of changes
Checklist: